-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove suggestion about extensions/syntax-hightlight #39
base: dev
Are you sure you want to change the base?
Conversation
It is rarely the case that highlighters have specific support for Z80, let alone RGBASM. Then, either there is specific support and it can be overridden (e.g. Sublime or VS Code's language choices), or either element is missing, in which case you should still be getting a fallback, which is still much better than absolutely no highlighting. (Even just dimming comments goes a long way.) |
The use case I imagine is "I use the same user account on the same PC to develop software for Game Boy and software for Master System, ZX Spectrum, MSX, or the Mega Drive audio CPU." In my personal case, it is Master System software. If I install a highlighter for the union of instructions recognized by the Game Boy CPU and instructions recognized by the Master System CPU, where
That's why I filed #35, so that if we do end up keeping "don't use a file extension meaning 'Zilog syntax for 8080 family'", the guide can cite instructions on how to override it in Sublime Text, Visual Studio Code, and GtkSourceView-based editors. |
I understood that, but my argument is that it's largely uncommon, and that it is subject to other constraints such as being viewed on GitHub, which has decent support for
Of course, but that 8080-family highlighter may simply have a higher priority for
Listing editor-specific instructions doesn't sound like a good idea to me, as we'd have to maintain all of them and possibly add more. Shouldn't a generic mention be sufficient? |
Regardless, while I disagree with removing the paragraph, I agree it should at least be reworded. |
I agree the z80 confusion should be clarified, but the paragraph (in the current status) does it badly:
This should just be explained in a clearer way, distinguishing the two concepts, avoiding smiles, etc. Let's just ditch the current version and propose something new |
See discussion in #35
@ISSOtm opinions?