Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that setting SC bit 7 is mandatory on slave to accept a Serial Data Transfer #556

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

avivace
Copy link
Member

@avivace avivace commented Jun 30, 2024

@quinnyo
Copy link
Contributor

quinnyo commented Jun 30, 2024

I think this looks good to merge, but there are some other instances of the same issue elsewhere on the page: in the intro and the very last paragraph (under 'Delays and Synchronization'). I don't know if you want to fix them as part of this PR or separately?

@avivace
Copy link
Member Author

avivace commented Jun 30, 2024

I think this looks good to merge, but there are some other instances of the same issue elsewhere on the page: in the intro and the very last paragraph (under 'Delays and Synchronization'). I don't know if you want to fix them as part of this PR or separately?

I'd say let's handle them all in this PR? I just pushed some more changes

@avivace avivace requested a review from ISSOtm July 1, 2024 18:07
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now wondering what value is obtained from attempting a transfer when the other GB(C) has not set its bit 7. Could it depend on the last transferred bit?

@avivace
Copy link
Member Author

avivace commented Jul 2, 2024

I'm now wondering what value is obtained from attempting a transfer when the other GB(C) has not set its bit 7. Could it depend on the last transferred bit?

maybe you can open a new 'research' issue regarding this?

@avivace avivace merged commit c190f66 into master Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants