Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old Licensee Code - add links, format hex properly. #560

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

Buggem
Copy link
Contributor

@Buggem Buggem commented Aug 3, 2024

I'm back! My 2 year late PR (remember #432, anyone?) to improve the Old Licensee Code section I added a long time ago. It adds relevant links to the companies (most of them, anyway) and formats the hex properly. I just revisited Game Boy reverse engineering and felt like the section needed a little polish.

@Buggem
Copy link
Contributor Author

Buggem commented Aug 3, 2024

Please ignore the failed checks, I've investigated and they appear to be caused by a dead link?

Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, hey, thank you very much! ^^

Copy link
Member

@avivace avivace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah! Thanks!

@avivace avivace merged commit 384e0d9 into gbdev:master Aug 3, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants