-
-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scramble banks from the end of the ROM #1273
Conversation
bcae4e5
to
4fa8a06
Compare
4fa8a06
to
8345e5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
2f3a97f
to
c2aafe7
Compare
Okay, now trying the next bank is updated too, not just assigning the first bank. Say you pass |
c2aafe7
to
fdf93cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Subject to testing by @eievui5 before release, preferably?
d613462
to
367fc34
Compare
The macOS tests give this error:
It's complaining about this line: trap "rm -f ${otemp@Q} ${gbtemp@Q} ${gbtemp2@Q} ${outtemp@Q}" EXIT I haven't changed the definitions of those temp files, so not sure what the actual problem is. My hypothesis would be that this line is responsible, since the rest of the new test is straightforwardly like the others: rom_size=$(wc -c <"$gbtemp") Except that Edit: Turns out macOS needed the |
This is more likely to test edge cases, such as having content in banks with their highest bit set.
6e9f831
to
8947be6
Compare
Tested and approved! |
This is more likely to test edge cases, such as having content in banks with their highest bit set.
Fixes #1036.
#1149 proposes allocating sections from the end of their individual banks. This is a similar approach, allocating section banks from the end of their overall ROM space.