Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests work with CTest #1539

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Make tests work with CTest #1539

merged 1 commit into from
Oct 15, 2024

Conversation

JL2210
Copy link
Contributor

@JL2210 JL2210 commented Oct 9, 2024

tests expect rgb{asm,link,fix,gfx} to be in ./

add CTestCustom.cmake to pull in dependencies

add option to disable non-free tests

Switch find_package conditions to explicitly state that it's broken on MacOS, and use pkg-config there only.

@Rangi42 Rangi42 marked this pull request as draft October 9, 2024 19:31
@Rangi42 Rangi42 added tests This affects the test suite meta This isn't related to the tools directly: repo organization, maintainership... builds This affects the build process or release artifacts labels Oct 9, 2024
@JL2210 JL2210 marked this pull request as ready for review October 14, 2024 01:50
@JL2210 JL2210 force-pushed the cmake-tests branch 3 times, most recently from af5c1ce to 34e4130 Compare October 14, 2024 18:28
@JL2210 JL2210 marked this pull request as draft October 14, 2024 18:38
tests expect rgb{asm,link,fix,gfx} to be in ./

add CTestCustom.cmake to pull in dependencies

add option to disable non-free tests

fix github actions
@JL2210 JL2210 marked this pull request as ready for review October 14, 2024 19:28
Copy link
Member

@ISSOtm ISSOtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about fine to me. Since in the end we are still using pkg-config for libpng, I think #1543 can also be closed?

@JL2210
Copy link
Contributor Author

JL2210 commented Oct 15, 2024

Looks about fine to me. Since in the end we are still using pkg-config for libpng, I think #1543 can also be closed?

Yeah. FindPNG is pretty unstable, evidently.

@Rangi42 Rangi42 added this to the v0.9.0 milestone Oct 15, 2024
@Rangi42 Rangi42 merged commit e623aeb into gbdev:master Oct 15, 2024
22 checks passed
@JL2210 JL2210 deleted the cmake-tests branch October 15, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds This affects the build process or release artifacts meta This isn't related to the tools directly: repo organization, maintainership... tests This affects the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants