Errors may occur at the first token of a line #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rangi42
added
bug
ISSOtm
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
The reason why this works is a little unintuitive, but the behaviour is correct. (If a syntax error occurs before the parser “enters” the line production, then that one's error recovery is not seen! So instead, reducing the syntax error as a lines lets us proceed with reducing more lines.)
Thank you for this investigation, @Rangi42!
(Side note: this might have been correct before we introduced diff_mark. I'm not too sure. But I'm not really concerned either.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't the first time we've had pre-existing test cases which should have made us aware of a bug if we'd really thought about their output. :P