Skip to content

Commit

Permalink
Revert: Bugfix: --balance will now enforce your drive_selection_algor…
Browse files Browse the repository at this point in the history
…ithm configuration on all files it works with (but will still not touch files smaller than 10MB)

This change caused issues where users using a 'forced' drive_selection_algorithm would get unbalanced drives!
  • Loading branch information
gboudreau committed Sep 23, 2013
1 parent 242b12a commit 709a044
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions greyhole
Original file line number Diff line number Diff line change
Expand Up @@ -4089,8 +4089,6 @@ function gh_balance() {

if ($is_sticky) {
gh_log(DEBUG, " Moving sticky file, even if that means it won't help balancing available space.");
} else if ($is_forced) {
gh_log(DEBUG, " Moving file per drive_selection_algorithm configuration, even if that means it won't help balancing available space.");
} else if ($pool_drives_avail_space[$source_drive]+$filesize+1*1024*1024 /*1GB*/ > $pool_drives_avail_space[$sp_drive]-$filesize
|| $pool_drives_avail_space[$source_drive]+$filesize > $target_avail_space
|| ($balance_direction_asc[$sp_drive] && $pool_drives_avail_space[$sp_drive] > $target_avail_space)
Expand Down

0 comments on commit 709a044

Please sign in to comment.