Filters 2.2.0 #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create ja_JP.inc by @tatsuyaueda
Added additional translations: Japanese - thanks to tatsuyaueda.
Added PHP requirements
Greek localization
Add config.inc.php
Add config.inc.php
Add config.inc.php
Fix "decode and search BASE64 messages"
Fix "decode and search BASE64 messages"
Added uk_UA.inc, thanks to Dmitro Gnatoyko
Added additional translations: Ukrainian - thanks to Dmitro Gnatoyko ([email protected])
When you first install filters plugin, there is an error with invalid argument supplied to foreach cycle on line 240, the rest of code crashes & it's not even shown the submit button then until this fix
Fixed no prefs error
Fix FR translations
Turkish lang file creatin. Türkçe dil dosyası eklendi.
Create turkish lang file
Update Spanish translation, including a missing string
Fix for roundcube 1.2.2
fix issue #31
Update filters.php
Update RCUBE_INPUT_POST to rcube_utils::INPUT_POST
Hungarian localization added
So that the output HTML is no longer skin-dependent. Signed-off-by: Jack Cherng <[email protected]>
Render settings sidebar with RC's PHP API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Days ago the following packages updated on FreeBSD:
php80 upgraded: 8.0.26 -> 8.0.28_1php80-pdo upgraded: 8.0.26 -> 8.0.28_1php80-zip upgraded: 8.0.26 -> 8.0.28_1php80-iconv upgraded: 8.0.26 -> 8.0.28_1php80-fileinfo upgraded: 8.0.26 -> 8.0.28_1php80-pdo_mysql upgraded: 8.0.26 -> 8.0.28_1php80-session upgraded: 8.0.26 -> 8.0.28_1php80-dom upgraded: 8.0.26 -> 8.0.28_1php80-xml upgraded: 8.0.26 -> 8.0.28_1php80-ctype upgraded: 8.0.26 -> 8.0.28_1php80-exif upgraded: 8.0.26 -> 8.0.28_1php80-mbstring upgraded: 8.0.26 -> 8.0.28_1php80-intl upgraded: 8.0.26_1 -> 8.0.28_1php80-filter upgraded: 8.0.26 -> 8.0.28_1php80-curl upgraded: 8.0.26 -> 8.0.28_1roundcube-php80 upgraded: 1.6.0,1 -> 1.6.1,1Due to this, the plugin stopped working and the webmail didn't show any inbox email due to Internal Server Error.
From the logs i saw:
[28-Apr-2023 08:59:13 UTC] PHP Fatal error: Uncaught TypeError: method_exists(): Argument #1 ($object_or_class) must be of type object|string, null given in /usr/local/www/roundcube/plugins/filters/filters.php:84 Stack trace: #0 /usr/local/www/roundcube/plugins/filters/filters.php(84): method_exists(NULL, 'get_mailbox_nam...') #1 /usr/local/www/roundcube/program/lib/Roundcube/rcube_plugin_api.php(518): filters->filters_checkmsg(Array) #2 /usr/local/www/roundcube/program/actions/mail/index.php(468): rcube_plugin_api->exec_hook('messages_list', Array) #3 /usr/local/www/roundcube/program/actions/mail/list.php(123): rcmail_action_mail_index::js_message_list(Array, false, Array) #4 /usr/local/www/roundcube/program/include/rcmail.php(282): rcmail_action_mail_list->run(Array) #5 /usr/local/www/roundcube/index.php(278): rcmail->action_handler() #6 {main} thrown in /usr/local/www/roundcube/plugins/filters/filters.php on line 84My workaround was to replace this string in
roundcube/plugins/filters/filters.php(line #84):if (method_exists($this->rc->imap,'get_mailbox_name')) {With this:
if ((is_string($this->rc->imap) || is_object($this->rc->imap)) && method_exists($this->rc->imap,'get_mailbox_name')) {The webmail started working again and the filters too.
I am creating this PR to allow the owner to create an update with official fix.