Innovation time - Github markdown model card details code highlighting #1581
Conversation
ghost
self-assigned this
|
Needs to have a custom theme for hightlight.js for WCAG accessibility with an appropriate contract ratio. |
| @@ -58,7 +58,8 @@ | |||
| "swagger-ui-react": "^5.17.14", | |||
| "swr": "^2.2.5", | |||
| "typescript": "5.5.3", | |||
| "uuid": "^10.0.0" | |||
| "uuid": "^10.0.0", | |||
| "react-syntax-highlighter": "15.5.0" | |||
There was a problem hiding this comment.
I'd expect there to be accompanying package-lock.json changes with installing a new package. Make sure those changes are also committed
| <Box | ||
| component='code' | ||
| sx={{ | ||
| backgroundColor: theme.palette.grey[200], |
There was a problem hiding this comment.
We should use a theme colour that works in both light and dark modes. A static colour will not work for both.
| }} | ||
| {...props} | ||
| > | ||
| {language ? <SyntaxHighlighter language={language}>{children}</SyntaxHighlighter> : children} |
There was a problem hiding this comment.
Check that all colours used by this package conform to accessibility contrast requirements for both light and dark mode themes.
|
KW86022 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
No description provided.