Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#161 case insensitive find entity by partial sign community and pattern #163

Conversation

twalmsley
Copy link
Collaborator

Also added a unit test with updated test data, and tested against my other project code.

@twalmsley twalmsley linked an issue Jan 17, 2024 that may be closed by this pull request
@twalmsley twalmsley self-assigned this Jan 17, 2024
@GCHQDeveloper42 GCHQDeveloper42 requested review from a team and removed request for GCHQDeveloper42 January 18, 2024 15:15
Copy link
Contributor

@GCHQDeveloper42 GCHQDeveloper42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending #156

@GCHQDeveloper42 GCHQDeveloper42 changed the title 161 case insensitive find entity by partial sign community and pattern #161 case insensitive find entity by partial sign community and pattern Jan 18, 2024
@GCHQDeveloper42 GCHQDeveloper42 force-pushed the 161-case-insensitive-find-entity-by-partial-sign-community-and-pattern branch from ef10919 to aea6d61 Compare January 18, 2024 17:19
@GCHQDeveloper42 GCHQDeveloper42 merged commit b07f2e2 into main Jan 18, 2024
3 checks passed
@GCHQDeveloper42 GCHQDeveloper42 deleted the 161-case-insensitive-find-entity-by-partial-sign-community-and-pattern branch January 18, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case-insensitive Find Entity By Partial Sign, Community, and Pattern
2 participants