KMM search android #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfernandezm
commented
Aug 30, 2023
kmm/kmm-feed/src/commonMain/kotlin/com/gchristov/newsfeed/kmmfeed/SearchWidgetState.kt
Show resolved
Hide resolved
dfernandezm
commented
Aug 30, 2023
...n-compose/src/main/java/com/gchristov/newsfeed/commoncompose/elements/search/AppSearchBar.kt
Show resolved
Hide resolved
|
Remaining TODO:
|
dfernandezm
force-pushed
the
feature/kmm-search-android
branch
from
5ff5b69
to
c8e0fcb
Compare
gchristov
approved these changes
Sep 11, 2023
| _state.postValue(newState) | ||
| // postValue vs setValue | ||
| // see: https://stackoverflow.com/questions/51299641/difference-of-setvalue-postvalue-in-mutablelivedata/51299672#51299672 | ||
| _state.setValue(newState, false) |
There was a problem hiding this comment.
What is the false here referring to? Might be nice to set argument names here so that it's clear.
There was a problem hiding this comment.
Will do in next PR
Comment on lines
+178
to
+179
| onTextChange: (String) -> Unit, | ||
| onCloseClicked: () -> Unit, |
There was a problem hiding this comment.
Nitpick: We could prefix this with onSearch so that it's clear what they refer to.
There was a problem hiding this comment.
Next PR will tackle this too
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feel free to delete irrelevant sections or add new ones as you see fit.
What does this pull request change?
Describe your proposed changes, including any necessary context.
Demo
Optional but helps to have a quick visual, if any.
Screenshots
Optional but helps to have a quick visual, if any.
How is this change tested?
How did you ensure your code works? e.g. unit tests, UI tests, manually
Our testing guide
Writing Kotlin Multiplatform tests