Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename iOS project and structure #30

Merged
merged 2 commits into from
Mar 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/workflows/check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,19 +91,19 @@ jobs:
uses: mikehardy/buildcache-action@v2
- name: Compile iOS app
run: |
cd appIos &&
cd ios &&
set -o pipefail &&
xcodebuild ${{ env.XCODE_CACHE }} -workspace appIos.xcworkspace -scheme "appIos" -sdk iphonesimulator -destination '${{ env.IOS_SIMULATOR }}' build | tee xcodebuild.log | xcpretty &&
xcodebuild ${{ env.XCODE_CACHE }} -workspace app.xcworkspace -scheme "app" -sdk iphonesimulator -destination '${{ env.IOS_SIMULATOR }}' build | tee xcodebuild.log | xcpretty &&
cd ..
- name: Artifacts
uses: actions/upload-artifact@v4
if: always() # Ensure all artifacts are collected, even after errors
with:
name: iOS Build
path: |
appIos/xcodebuild.log
~/Library/Developer/Xcode/DerivedData/**/Build/Products/**/appIos.app
~/Library/Developer/Xcode/DerivedData/**/Build/Products/**/appIos.app.dSYM
ios/xcodebuild.log
~/Library/**/app.app
~/Library/**/app.app.dSYM
**/build
**/secrets.properties

Expand Down Expand Up @@ -137,17 +137,17 @@ jobs:
uses: mikehardy/buildcache-action@v2
- name: iOS tests
run: |
cd appIos &&
cd ios &&
set -o pipefail &&
xcodebuild ${{ env.XCODE_CACHE }} -workspace appIos.xcworkspace -scheme "appIos" -sdk iphonesimulator -destination '${{ env.IOS_SIMULATOR }}' test | tee xcodebuild.log | xcpretty &&
xcodebuild ${{ env.XCODE_CACHE }} -workspace app.xcworkspace -scheme "app" -sdk iphonesimulator -destination '${{ env.IOS_SIMULATOR }}' test | tee xcodebuild.log | xcpretty &&
cd ..
- name: Artifacts
uses: actions/upload-artifact@v4
if: always() # Ensure all artifacts are collected, even after errors
with:
name: iOS Tests
path: |
appIos/xcodebuild.log
ios/xcodebuild.log

android-check-build:
runs-on: ubuntu-20.04
Expand Down
20 changes: 10 additions & 10 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,14 @@ build
.externalNativeBuild
.cxx
local.properties
appIos/appIos.xcodeproj/project.xcworkspace/xcuserdata
appIos/appIos.xcodeproj/xcuserdata
appIos/appIos.xcworkspace/xcuserdata
appIos/feed/feed.xcodeproj/xcuserdata
appIos/post/post.xcodeproj/xcuserdata
appIos/common-swiftui/common-swiftui.xcodeproj/xcuserdata
appIos/common-design/common-design.xcodeproj/xcuserdata
appIos/common-swiftui-test/common-swiftui-test.xcodeproj/xcuserdata
appIos/feed-test-fixtures/feed-test-fixtures.xcodeproj/xcuserdata
appIos/post-test-fixtures/post-test-fixtures.xcodeproj/xcuserdata
ios/app.xcodeproj/project.xcworkspace/xcuserdata
ios/app.xcodeproj/xcuserdata
ios/app.xcworkspace/xcuserdata
ios/feed/feed.xcodeproj/xcuserdata
ios/post/post.xcodeproj/xcuserdata
ios/common-swiftui/common-swiftui.xcodeproj/xcuserdata
ios/common-design/common-design.xcodeproj/xcuserdata
ios/common-swiftui-test/common-swiftui-test.xcodeproj/xcuserdata
ios/feed-test-fixtures/feed-test-fixtures.xcodeproj/xcuserdata
ios/post-test-fixtures/post-test-fixtures.xcodeproj/xcuserdata
secrets.properties
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
464126B02722FC960094BF9B /* Feed.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = Feed.framework; sourceTree = BUILT_PRODUCTS_DIR; };
4644B9162785234A0067B224 /* CommonDesign.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = CommonDesign.framework; sourceTree = BUILT_PRODUCTS_DIR; };
4652716D2764E86E0025EA10 /* CommonSwiftUi.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; path = CommonSwiftUi.framework; sourceTree = BUILT_PRODUCTS_DIR; };
7555FF7B242A565900829871 /* appIos.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = appIos.app; sourceTree = BUILT_PRODUCTS_DIR; };
7555FF7B242A565900829871 /* app.app */ = {isa = PBXFileReference; explicitFileType = wrapper.application; includeInIndex = 0; path = app.app; sourceTree = BUILT_PRODUCTS_DIR; };
7555FF8C242A565B00829871 /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
/* End PBXFileReference section */

Expand All @@ -63,7 +63,7 @@
7555FF72242A565900829871 = {
isa = PBXGroup;
children = (
7555FF7D242A565900829871 /* appIos */,
7555FF7D242A565900829871 /* app */,
7555FF7C242A565900829871 /* Products */,
7555FFB0242A642200829871 /* Frameworks */,
);
Expand All @@ -72,18 +72,18 @@
7555FF7C242A565900829871 /* Products */ = {
isa = PBXGroup;
children = (
7555FF7B242A565900829871 /* appIos.app */,
7555FF7B242A565900829871 /* app.app */,
);
name = Products;
sourceTree = "<group>";
};
7555FF7D242A565900829871 /* appIos */ = {
7555FF7D242A565900829871 /* app */ = {
isa = PBXGroup;
children = (
7555FF8C242A565B00829871 /* Info.plist */,
2152FB032600AC8F00CF470E /* NewsfeedApp.swift */,
);
path = appIos;
path = app;
sourceTree = "<group>";
};
7555FFB0242A642200829871 /* Frameworks */ = {
Expand All @@ -100,9 +100,9 @@
/* End PBXGroup section */

/* Begin PBXNativeTarget section */
7555FF7A242A565900829871 /* appIos */ = {
7555FF7A242A565900829871 /* app */ = {
isa = PBXNativeTarget;
buildConfigurationList = 7555FFA5242A565B00829871 /* Build configuration list for PBXNativeTarget "appIos" */;
buildConfigurationList = 7555FFA5242A565B00829871 /* Build configuration list for PBXNativeTarget "app" */;
buildPhases = (
4680F45927A5E5D5007DA70E /* ShellScript */,
7555FF77242A565900829871 /* Sources */,
Expand All @@ -114,11 +114,11 @@
);
dependencies = (
);
name = appIos;
name = app;
packageProductDependencies = (
);
productName = appIos;
productReference = 7555FF7B242A565900829871 /* appIos.app */;
productName = app;
productReference = 7555FF7B242A565900829871 /* app.app */;
productType = "com.apple.product-type.application";
};
/* End PBXNativeTarget section */
Expand All @@ -136,7 +136,7 @@
};
};
};
buildConfigurationList = 7555FF76242A565900829871 /* Build configuration list for PBXProject "appIos" */;
buildConfigurationList = 7555FF76242A565900829871 /* Build configuration list for PBXProject "app" */;
compatibilityVersion = "Xcode 9.3";
developmentRegion = en;
hasScannedForEncodings = 0;
Expand All @@ -152,7 +152,7 @@
projectDirPath = "";
projectRoot = "";
targets = (
7555FF7A242A565900829871 /* appIos */,
7555FF7A242A565900829871 /* app */,
);
};
/* End PBXProject section */
Expand Down Expand Up @@ -323,7 +323,7 @@
DEVELOPMENT_TEAM = 5G893F5HW7;
ENABLE_PREVIEWS = YES;
FRAMEWORK_SEARCH_PATHS = "$(SRCROOT)/../multiplatform/umbrella/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)";
INFOPLIST_FILE = appIos/Info.plist;
INFOPLIST_FILE = app/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 15.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
Expand All @@ -345,7 +345,7 @@
DEVELOPMENT_TEAM = 5G893F5HW7;
ENABLE_PREVIEWS = YES;
FRAMEWORK_SEARCH_PATHS = "$(SRCROOT)/../multiplatform/umbrella/build/xcode-frameworks/$(CONFIGURATION)/$(SDK_NAME)";
INFOPLIST_FILE = appIos/Info.plist;
INFOPLIST_FILE = app/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 15.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
Expand All @@ -362,7 +362,7 @@
/* End XCBuildConfiguration section */

/* Begin XCConfigurationList section */
7555FF76242A565900829871 /* Build configuration list for PBXProject "appIos" */ = {
7555FF76242A565900829871 /* Build configuration list for PBXProject "app" */ = {
isa = XCConfigurationList;
buildConfigurations = (
7555FFA3242A565B00829871 /* Debug */,
Expand All @@ -371,7 +371,7 @@
defaultConfigurationIsVisible = 0;
defaultConfigurationName = Release;
};
7555FFA5242A565B00829871 /* Build configuration list for PBXNativeTarget "appIos" */ = {
7555FFA5242A565B00829871 /* Build configuration list for PBXNativeTarget "app" */ = {
isa = XCConfigurationList;
buildConfigurations = (
7555FFA6242A565B00829871 /* Debug */,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "7555FF7A242A565900829871"
BuildableName = "appIos.app"
BlueprintName = "appIos"
ReferencedContainer = "container:appIos.xcodeproj">
BuildableName = "app.app"
BlueprintName = "app"
ReferencedContainer = "container:app.xcodeproj">
</BuildableReference>
</BuildActionEntry>
</BuildActionEntries>
Expand Down Expand Up @@ -65,9 +65,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "7555FF7A242A565900829871"
BuildableName = "appIos.app"
BlueprintName = "appIos"
ReferencedContainer = "container:appIos.xcodeproj">
BuildableName = "app.app"
BlueprintName = "app"
ReferencedContainer = "container:app.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</LaunchAction>
Expand All @@ -82,9 +82,9 @@
<BuildableReference
BuildableIdentifier = "primary"
BlueprintIdentifier = "7555FF7A242A565900829871"
BuildableName = "appIos.app"
BlueprintName = "appIos"
ReferencedContainer = "container:appIos.xcodeproj">
BuildableName = "app.app"
BlueprintName = "app"
ReferencedContainer = "container:app.xcodeproj">
</BuildableReference>
</BuildableProductRunnable>
</ProfileAction>
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Loading