Wrong 'this' destroyed when a server error is received #116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On receiving a server error frame an 'end' event handler is added to the incoming frame. Within this handler
this
refers to the incoming frame not theClient
instance. The handler inadvertently callsdestroy
on the incoming frame and causes an uncaught exception.destroy
should be called on theClient
instance to allow client code to attach anon('error', ....)
handler.