Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong 'this' destroyed when a server error is received #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robinsummerhill
Copy link

On receiving a server error frame an 'end' event handler is added to the incoming frame. Within this handler this refers to the incoming frame not the Client instance. The handler inadvertently calls destroy on the incoming frame and causes an uncaught exception.

destroy should be called on the Client instance to allow client code to attach an on('error', ....) handler.

@robinsummerhill robinsummerhill changed the title Fix destroying wrong 'this' when server error received Wrong 'this' destroyed when a server error is received Dec 18, 2020
@teemall
Copy link

teemall commented May 2, 2024

uhhh....so looks like there's no movement on this :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants