Prototype for supporting vcpkg #12
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your patch! As discussed on #8 we are still not clear if and how we'd like to support |
Open
This seems to be the favored way for finding libraries under msvc, and the `vcpkg` crate is a reverse dependency of various -sys crates. It seems to have some issues as is. Vcpkg doesn't seem to have support for finding a particular version of a package. And with this, `glib-sys`, for instance, still fails to build without changes because it needs to search for just `glib`, not `glib-2.0`. Perhaps the solution is to add an optional `vcpkg_name` that can be specified in toml? But in any case, this shows what's involved in supporting vcpkg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be the favored way for finding libraries under msvc, and the
vcpkgcrate is a reverse dependency of various -sys crates.It seems to have some issues as is. Vcpkg doesn't seem to have support for finding a particular version of a package. And with this,
glib-sys, for instance, still fails to build without changes because it needs to search for justglib, notglib-2.0.Perhaps the solution is to add an optional
vcpkg_namethat can be specified in toml? But in any case, this shows what's involved in supporting vcpkg.Not sure if this should be merged as is, but it shouldn't cause any problems since it's disabled by default.
#8