Update gdsfactory829

[joamatab]

Summary by Sourcery

Refactor FET and diode drawing functions to use relative coordinates.

Bug Fixes:

• Fixed a bug where absolute coordinates were used instead of relative coordinates in the FET and diode drawing functions.

Enhancements:

• Improved the readability and maintainability of the FET and diode drawing functions by using relative coordinates.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request updates the gf180/cells/klayout/pymacros/cells library to use the new dx and dy properties instead of xmin, xmax, ymin, and ymax properties for getting the bounding box dimensions of components.

Class diagram showing the property name changes

classDiagram
    class Component {
        -size
        -position
        +dxmin
        +dxmax
        +dymin
        +dymax
        +dmove(dx, dy)
        note for Component "Changed from xmin/xmax/ymin/ymax
to dxmin/dxmax/dymin/dymax"
    }

    class Rectangle {
        +size
        +layer
        +dxmin
        +dxmax
        +dymin
        +dymax
        +dmove(dx, dy)
    }

    Component <|-- Rectangle

Loading

File-Level Changes

Change	Details	Files
Updated bounding box dimension accessors	Replaced xmin, xmax, ymin, and ymax with dxmin, dxmax, dymin, and dymax respectively. Replaced x_range and y_range with dx_range and dy_range respectively in via_generator and via_stack functions. Updated list comprehensions to use dx instead of x when appending elements based on bounding box dimensions. Updated movex, movey, and move function calls with dmovex, dmovey, and dmove respectively. Updated connect function calls to use the new port connection syntax. Updated f-string formatting to use the new format specifier.	gf180/cells/klayout/pymacros/cells/draw_fet.py gf180/diode.py gf180/cells/klayout/pymacros/cells/draw_diode.py gf180/fet.py gf180/cells/klayout/pymacros/cells/draw_res.py gf180/res.py gf180/cap_mos.py gf180/cells/klayout/pymacros/cells/draw_cap_mos.py gf180/cap_mim.py gf180/cells/klayout/pymacros/cells/draw_cap_mim.py gf180/layers.py gf180/via_generator.py gf180/cells/klayout/pymacros/cells/via_generator.py gf180/guardring.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "cap_mim(L=" + (f"{self.lc:.3f}") + ",W=" + (f"{self.wc:.3f}") + ")"
	return f"cap_mim(L={self.lc:.3f},W=" + f"{self.wc:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "cap_nmos(LC=" + (f"{self.lc:.3f}") + ",WC=" + (f"{self.wc:.3f}") + ")"
	return f"cap_nmos(LC={self.lc:.3f},WC=" + f"{self.wc:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "cap_pmos(LC=" + (f"{self.lc:.3f}") + ",WC=" + (f"{self.wc:.3f}") + ")"
	return f"cap_pmos(LC={self.lc:.3f},WC=" + f"{self.wc:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "cap_nmos_b(LC=" + (f"{self.lc:.3f}") + ",WC=" + (f"{self.wc:.3f}") + ")"
	return f"cap_nmos_b(LC={self.lc:.3f},WC=" + f"{self.wc:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "cap_pmos_b(LC=" + (f"{self.lc:.3f}") + ",WC=" + (f"{self.wc:.3f}") + ")"
	return f"cap_pmos_b(LC={self.lc:.3f},WC=" + f"{self.wc:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "diode_pw2dw(L=" + (f"{self.la:.3f}") + ",W=" + (f"{self.wa:.3f}") + ")"
	return f"diode_pw2dw(L={self.la:.3f},W=" + f"{self.wa:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "diode_dw2ps(L=" + (f"{self.la:.3f}") + ",W=" + (f"{self.wa:.3f}") + ")"
	return f"diode_dw2ps(L={self.la:.3f},W=" + f"{self.wa:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "sc_diode(L=" + (f"{self.la:.3f}") + ",W=" + (f"{self.wa:.3f}") + ")"
	return f"sc_diode(L={self.la:.3f},W=" + f"{self.wa:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "nfet(L=" + (f"{self.l_gate:.3f}") + ",W=" + (f"{self.w_gate:.3f}") + ")"
	return f"nfet(L={self.l_gate:.3f},W=" + f"{self.w_gate:.3f}" + ")"

[sourcery-ai]

suggestion (code-quality): Use f-string instead of string concatenation [×2] (use-fstring-for-concatenation)

Suggested change

	return "pfet(L=" + (f"{self.l_gate:.3f}") + ",W=" + (f"{self.w_gate:.3f}") + ")"
	return f"pfet(L={self.l_gate:.3f},W=" + f"{self.w_gate:.3f}" + ")"