Merge pull request #239 from gdsfactory/tidy3d_rework2

Tidy3d rework2
gdsfactory · Nov 28, 2023 · 9b8ee3f · 9b8ee3f
2 parents 4595663 + 97fda6a
commit 9b8ee3f
Show file tree

Hide file tree

Showing 26 changed files with 1,362 additions and 1,437 deletions.
diff --git a/.github/workflows/pages.yml b/.github/workflows/pages.yml
@@ -30,7 +30,7 @@ jobs:
           eval "$(micromamba shell hook --shell=bash)"
           micromamba activate
           micromamba install -c conda-forge pymeep=*=mpi_mpich_* nlopt -y
-          make dev
+          make dev test-data
           make docs
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v2

diff --git a/.github/workflows/test_code.yml b/.github/workflows/test_code.yml
@@ -143,6 +143,7 @@ jobs:
           eval "$(micromamba shell hook --shell=bash)"
           micromamba activate
           micromamba install -c conda-forge pymeep=*=mpi_mpich_* nlopt -y
+          make test-data
           make dev
           make docs
       - name: Expose docs artifact

diff --git a/.gitignore b/.gitignore
@@ -4,6 +4,7 @@ __pycache__/
 *$py.class
 temp.msh2
 docs/notebooks/temporary
+docs/notebooks/batch-*
 
 # C extensions
 *.so

diff --git a/Makefile b/Makefile
@@ -22,7 +22,7 @@ cov:
 test-data:
 	git clone https://github.com/gdsfactory/gdsfactory-test-data.git -b test-data test-data
 
-test-data-developers:
+test-data-ssh:
 	git clone [email protected]:gdsfactory/gdsfactory-test-data.git -b test-data test-data
 
 git-rm-merged:

diff --git a/docs/api_design.rst b/docs/api_design.rst
@@ -143,7 +143,6 @@ FDTD Simulation
    :toctree: _autosummary/
 
    write_sparameters
-   write_sparameters_batch
    write_sparameters_grating_coupler
    write_sparameters_grating_coupler_batch