Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy3d rework #138

Merged
merged 35 commits into from
Nov 28, 2023
Merged

tidy3d rework #138

merged 35 commits into from
Nov 28, 2023

Conversation

yaugenst
Copy link
Collaborator

This is a WIP for the rewrite of the tidy3d plugin.
Adds a SimulationComponentBase class from which simulators can inherit and that should expose everything that's necessary to derive simulation geometries for different simulation backends.
Implements a Tidy3DComponent class which builds tidy3d Polyslabs from that information.
The sparameter simulation is still missing but will be easy to add once I actually converge on the interface here.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (8509251) 39.54% compared to head (a2027f9) 38.55%.
Report is 106 commits behind head on main.

❗ Current head a2027f9 differs from pull request most recent head 8b2dac0. Consider uploading reports for the commit 8b2dac0 to get more accurate results

Files Patch % Lines
gplugins/tidy3d/component.py 31.88% 47 Missing ⚠️
gplugins/klayout/drc/write_drc.py 27.77% 13 Missing ⚠️
gplugins/common/base_models/component.py 40.00% 6 Missing ⚠️
gplugins/tidy3d/types.py 75.00% 2 Missing ⚠️
gplugins/tidy3d/util.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
- Coverage   39.54%   38.55%   -1.00%     
==========================================
  Files         175      161      -14     
  Lines       10496     9281    -1215     
==========================================
- Hits         4151     3578     -573     
+ Misses       6345     5703     -642     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joamatab
Copy link
Contributor

Looks great Yannick!

it would be great to increase the test coverage of some of the new functions

@yaugenst
Copy link
Collaborator Author

Yeah this is not ready to be merged, I submitted the draft mostly so that I have a reference for #139

@joamatab
Copy link
Contributor

i'd recommend moving the common Classses to gplugins.typings

then in future PRs we can convert the other plugins to use this

@joamatab
Copy link
Contributor

joamatab commented Sep 19, 2023

@yaugenst yaugenst marked this pull request as ready for review November 16, 2023 22:18
@yaugenst yaugenst requested a review from joamatab November 16, 2023 22:18
@yaugenst
Copy link
Collaborator Author

@joamatab the functionality is there, no example notebooks yet though. can merge if you want

@joamatab
Copy link
Contributor

looks great!

I think you are missing meshio dependency from gmsh for the tests to pass

once tests pass we can merge it

@yaugenst
Copy link
Collaborator Author

@joamatab dependency issues are fixed, tests are not passing because pytest is not finding any (there are none right now)

@joamatab joamatab merged commit 1508b29 into gdsfactory:main Nov 28, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants