-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidy3d rework #138
tidy3d rework #138
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 39.54% 38.55% -1.00%
==========================================
Files 175 161 -14
Lines 10496 9281 -1215
==========================================
- Hits 4151 3578 -573
+ Misses 6345 5703 -642 ☔ View full report in Codecov by Sentry. |
Looks great Yannick! it would be great to increase the test coverage of some of the new functions |
Yeah this is not ready to be merged, I submitted the draft mostly so that I have a reference for #139 |
i'd recommend moving the common Classses to then in future PRs we can convert the other plugins to use this |
22a6667
to
8454cf1
Compare
@joamatab the functionality is there, no example notebooks yet though. can merge if you want |
looks great! I think you are missing meshio dependency from gmsh for the tests to pass once tests pass we can merge it |
@joamatab dependency issues are fixed, tests are not passing because pytest is not finding any (there are none right now) |
This is a WIP for the rewrite of the tidy3d plugin.
Adds a SimulationComponentBase class from which simulators can inherit and that should expose everything that's necessary to derive simulation geometries for different simulation backends.
Implements a Tidy3DComponent class which builds tidy3d Polyslabs from that information.
The sparameter simulation is still missing but will be easy to add once I actually converge on the interface here.