Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Elmer & Palace tests #195

Merged
merged 4 commits into from
Oct 17, 2023
Merged

Fix Elmer & Palace tests #195

merged 4 commits into from
Oct 17, 2023

Conversation

nikosavola
Copy link
Member

This PR fixes elmer and palace tests not working after changes in #157.

  • Elmer notebook run in docs
  • Elmer tests run in CI (working in https://github.com/nikosavola/gplugins/actions/runs/6553047836/job/17797631957)
    • not tested for 4 cores, as default github runners only have two
  • layer-port delimiter for argument is added to meshing functions and propagated to the delimiter argument in get_component_with_net_layers
    • required as the default # is not allowed for Elmer

Closes #158

@nikosavola nikosavola changed the title 158 fix elmer and palace tests Fix Elmer & Palace tests Oct 17, 2023
@nikosavola nikosavola force-pushed the 158-fix-elmer-and-palace-tests branch from 16a6f51 to 3d990ad Compare October 17, 2023 22:28
@joamatab joamatab merged commit 12373f4 into gdsfactory:main Oct 17, 2023
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix elmer and palace
2 participants
@nikosavola @joamatab