New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dataprep #216

Merged

joamatab merged 3 commits into gdsfactory:main from tvt173:improve-dataprep

Nov 2, 2023

Collaborator

tvt173 commented Nov 1, 2023

This PR primarily does two things

Avoids flattening of untouched layers from the source gds when included in the output with keep_original=True
Allows the user to check if a layer exists in the RegionCollection by implementing the __contains__ magic method

tvt173 and others added 3 commits

November 1, 2023 18:02


          avoid flattening when necessary and add contains check

5f00734


          cleaning up layer assertions

f0c47da


          [pre-commit.ci] auto fixes from pre-commit.com hooks

d6ba6b9

for more information, see https://pre-commit.ci

joamatab merged commit a41eb42 into gdsfactory:main

12 checks passed

nikosavola mentioned this pull request

Remove HSPICE netlist comments for plot_nets #218

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet