Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_simulation.py (component_ref.ports correction) #476

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

kdotom
Copy link
Contributor

@kdotom kdotom commented Aug 23, 2024

Error occurs. (index out of range) Assuming "port in component_ref" should be "port in component_ref.ports."

If otherwise / if there is another solution for the error, feel free to reply.

Error occurs. (index out of range) Assuming "port in component_ref" should be "port in component_ref.ports"
Copy link
Contributor

sourcery-ai bot commented Aug 23, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@joamatab joamatab merged commit f290b98 into gdsfactory:main Aug 26, 2024
4 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants