Skip to content

Commit

Permalink
Merge pull request #325 from gdsfactory/fix_ring_double
Browse files Browse the repository at this point in the history
Fix ring double
  • Loading branch information
joamatab authored Oct 21, 2023
2 parents a780319 + 49f90f9 commit 40ac77f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
8 changes: 3 additions & 5 deletions tests/test_components/test_pdk_settings_ring_double_.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: ring_double_a555db4c
name: ring_double_1628c13a
settings:
changed:
bend:
function: bend_euler_sc
coupler_ring:
function: coupler_ring
settings:
Expand Down Expand Up @@ -97,7 +95,7 @@ settings:
function: straight
full:
bend:
function: bend_euler_sc
function: bend_euler
coupler_ring:
function: coupler_ring
settings:
Expand Down Expand Up @@ -185,4 +183,4 @@ settings:
info: {}
info_version: 2
module: gdsfactory.components.ring_double
name: ring_double_a555db4c
name: ring_double_1628c13a
4 changes: 2 additions & 2 deletions ubcpdk/components.py
Original file line number Diff line number Diff line change
Expand Up @@ -736,7 +736,6 @@ def ebeam_dc_halfring_straight(
gf.components.ring_double,
coupler_ring=coupler_ring,
cross_section=tech.xs_sc,
bend=bend,
straight=straight,
)
ring_double_heater = partial(
Expand Down Expand Up @@ -857,6 +856,7 @@ def add_pads(


if __name__ == "__main__":
c = ring_double(length_y=10)
# c = ring_with_crossing()
# c = mmi1x2()
# c = add_fiber_array(mzi)
Expand All @@ -873,5 +873,5 @@ def add_pads(
# c = ring_single_heater()
# c = ebeam_dc_halfring_straight()
# c = ring_with_crossing()
c = ring_single()
# c = ring_single()
c.show(show_ports=False)

0 comments on commit 40ac77f

Please sign in to comment.