Fixed CodeQL gripes with usage of c_str() pointers after the lifetime…

… of the std::string objects. (#404) Co-authored-by: Ed Sabol <[email protected]>
gearman · Aug 4, 2024 · 6816e06 · 6816e06
1 parent 47f232c
commit 6816e06
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/libtest/signal.cc b/libtest/signal.cc
@@ -244,8 +244,8 @@ bool SignalThread::setup()
 {
   set_shutdown(SHUTDOWN_RUNNING);
 
-  const char * lock_name = random_lock_name().c_str();
-  lock = sem_open(lock_name, O_CREAT|O_EXCL, S_IRUSR|S_IWUSR, 0);
+  std::string lock_name = random_lock_name();
+  lock = sem_open(lock_name.c_str(), O_CREAT|O_EXCL, S_IRUSR|S_IWUSR, 0);
   if (lock == SEM_FAILED)
   {
     Error << errno << ": " << strerror(errno)

diff --git a/util/signal.cc b/util/signal.cc
@@ -246,8 +246,8 @@ bool SignalThread::setup()
     return false;
   }
 
-  const char * lock_name = random_lock_name().c_str();
-  lock = sem_open(lock_name, O_CREAT|O_EXCL, S_IRUSR|S_IWUSR, 0);
+  std::string lock_name = random_lock_name();
+  lock = sem_open(lock_name.c_str(), O_CREAT|O_EXCL, S_IRUSR|S_IWUSR, 0);
   if (lock == SEM_FAILED) {
     std::cerr << "WARNING: sem_open failed(" << strerror(errno) << ")"
               << " when opening lock '" << lock_name << "'." << std::endl;