Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing basic CodeQL alerts #384

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Fixing basic CodeQL alerts #384

merged 2 commits into from
Nov 24, 2023

Conversation

SpamapS
Copy link
Member

@SpamapS SpamapS commented Nov 22, 2023

Many of these are just typing problems in debug logs and such. However, more-defined behavior is better than undefined, so we'll center on those. This may change some log lines but that's not really a surface whose behaviors we plan to guarantee.

Many of these are just typing problems in debug logs and such. However,
more-defined behavior is better than undefined, so we'll center on
those. This may change some log lines but that's not really a surface
whose behaviors we plan to guarantee.
Copy link
Member

@esabol esabol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, all of these changes look good to me. Thanks, @SpamapS !

@SpamapS SpamapS merged commit 581f757 into master Nov 24, 2023
12 checks passed
@esabol esabol added the codeql label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants