Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to LiveScript, and fixing a few blocker bugs #6

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

audreyt
Copy link

@audreyt audreyt commented Nov 1, 2012

This fixed a few blocker issues:

  • Inability to type \ or " into a table cell.
  • Inability to type the string "data-tables" into a table cell.
  • Clicking one of the list toolbars corrupts the table.

It would be nice if we can allow inline styles (bold/italic/underline) within a table cell, but I think it's a good checkpoint for you to consider merging.

Thank you for the great initial work!

@gedion
Copy link
Owner

gedion commented Nov 2, 2012

Hello. This is pretty amazing. Thank you for taking your time and for suffering through the maze.
I'm really excited on how much you have cleaned it up. I don't have much familiarity with LiveScript but I'll still go through the implementation and send feedback.

Here are some initial test cases that broke the pad. 1) is a new error I believe. 2) also exists in original implementation. However the stuck in 'Loading...' state is new I believe.

  1. Entering a url (example: https://www.google.com) within a cell causes a 'Uncaught SyntaxError: JSON.parse: "," "]],"tblId":"1","tblClass":"\ufff9"}' error.
    Refreshing the pad leaves the 'Loading...' state

  2. Highlighting more than one cell and deleting them causes erotic behavior that includes continues new line with text entry in the pad and caret position jumping. Refreshing the pad leaves the 'Loading...' state

I will do a more thorough testing in the coming days.

@audreyt
Copy link
Author

audreyt commented Nov 5, 2012

Thanks, 1) was fixed by clkao in 9a3e7fe... As re 2), we've observed the erratic behavior as well. The workaround for now I guess is to disallow the delete keys when selection spans multiple cells?

@clkao
Copy link

clkao commented Nov 5, 2012

Note that for 2) it's basically keyevent (replace or delete) needs to check for user selection with the same logic of isCellDeleteOk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants