-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Porting to LiveScript, and fixing a few blocker bugs #6
base: master
Are you sure you want to change the base?
Conversation
…ake the buttons look disabled
Hello. This is pretty amazing. Thank you for taking your time and for suffering through the maze. Here are some initial test cases that broke the pad. 1) is a new error I believe. 2) also exists in original implementation. However the stuck in 'Loading...' state is new I believe.
I will do a more thorough testing in the coming days. |
…an.url do not break the payload.
Thanks, 1) was fixed by clkao in 9a3e7fe... As re 2), we've observed the erratic behavior as well. The workaround for now I guess is to disallow the delete keys when selection spans multiple cells? |
Note that for 2) it's basically keyevent (replace or delete) needs to check for user selection with the same logic of isCellDeleteOk |
This fixed a few blocker issues:
It would be nice if we can allow inline styles (bold/italic/underline) within a table cell, but I think it's a good checkpoint for you to consider merging.
Thank you for the great initial work!