Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize imports #226

Closed
wants to merge 2 commits into from
Closed

Normalize imports #226

wants to merge 2 commits into from

Conversation

alukach
Copy link
Collaborator

@alukach alukach commented Feb 11, 2025

This PR is a quick refactor to normalize how imports occur within this plugin. I'm not aware of any advantage of delaying imports until methods are called within this codebase. Often this technique is used to avoid circular dependencies, however that in itself is a code-smell that indicates incorrectly organized code. By removing the unused update_ee_layer_properties function, we eliminate any circular dependencies and are thus able to use a standard import pattern.

@alukach alukach requested a review from zacdezgeo February 11, 2025 18:55
@alukach alukach closed this Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant