Add "Add Feature Collection" button, buildout menu tooling

[alukach]

What I'm changing

This PR builds out a menu for the add_vector_layer() tooling that we currently have within the system:

qgis-earthengine-plugin/ee_plugin/utils.py

Lines 202 to 248 in 08e7bb8

	def add_ee_vector_layer(
	eeObject: ee.Element,
	name: str,
	shown: bool = True,
	opacity: float = 1.0,
	) -> QgsVectorLayer:
	"""
	Adds a vector layer properly by converting EE Geometry to a valid GeoJSON FeatureCollection.
	"""
	# Convert EE geometry into a proper GeoJSON FeatureCollection
	geometry_info = eeObject.getInfo()
	geojson = {
	"type": "FeatureCollection",
	"features": [
	{
	"type": "Feature",
	"geometry": geometry_info,
	"properties": {}, # Empty properties
	}
	],
	}
	# Write to a temporary file for QGIS
	temp_file = tempfile.NamedTemporaryFile(delete=False, suffix=".geojson")
	with open(temp_file.name, "w") as f:
	json.dump(geojson, f)
	# Use the temp file as the data source
	uri = temp_file.name
	# Create the vector layer
	layer = QgsVectorLayer(uri, name, "ogr")
	if not layer.isValid():
	print(f"Failed to load vector layer: {name}")
	else:
	QgsProject.instance().addMapLayer(layer)
	if shown is not None:
	QgsProject.instance().layerTreeRoot().findLayer(
	layer.id()
	).setItemVisibilityChecked(shown)
	if opacity is not None and layer.renderer():
	symbol = layer.renderer().symbol()
	symbol.setOpacity(opacity)
	layer.triggerRepaint()
	return layer

How I did it

While adding a menu for this one function, I experimented with several techniques for creating UIs within QGIS. This included using QtDesigner to generate a .ui file, which could be parsed in Python or converted to Python. Ultimately, I elected not to go with either of these methods, as the .ui files would likely prove a challenge when attempting to build & maintain cohesively styled UIs within the plugin, and the Python conversions were very crudely constructed, which looked as if they would make for a maintenance challenge. Instead, I opted to build out some helper functions that could be used to build out consistent UI patterns that would be easily read & maintained.

[zacdezgeo]

Very little changes to push this through. Mostly flagged items to be addressed in future refactor. Perhaps just the commented buttons to be removed?

[zacdezgeo]

Nice! I'm wondering if when we should implement the sub-menus to avoid having a long list of functions at the top level. We can punt beyond this PR.

[alukach]

I'm wondering if when we should implement the sub-menus to ...

Not sure what you're saying here.

[zacdezgeo]

Basically, have an "EE Tools" or something like at the top level and list the specific forms available under this sub-menu. In a similar way to how other menus work in QGIS:

[alukach]

How does this look to you?

[zacdezgeo]

Is none used for some whitespace or something? Wondering if we should extract this to another function that potentially takes a list of actions, and figures out the formatting. With the sub-menu logic, we could also maybe use a dictionary that maps to the sub-menu/level desired? Again, we can refactor after this PR.

[alukach]

Yeah, this is something that I was unsure about. If you look below, you'll see:

                if action:
                    menu.addAction(action)
                else:
                    menu.addSeparator()

So basically, None represents a separator. That feels like an awkward convention but wasn't sure what would be better. I also am unsure that we want to keep the plugin menu and toolbar menu completely in sync as we are doing now.

[alukach]

In 6036c7c, I abstracted how the menu is setup.

[zacdezgeo]

Nice! I'm wondering if we would like to have a single file per form to avoid them being to clustered in the future. Is listing all these files under the ui folder a good idea? That's the approach I took in #229.

[zacdezgeo]

It could also be under a new python package called forms in terms of project structure 🤷

[alukach]

I think separating the forms and possibly their handler into separate files seems like a good idea.

[alukach]

@zacdezgeo what do you think about 864a1e5?

[zacdezgeo]

looks great! Probably a nit, but can we add the form prefix to any form to help differentiate from the other UI files and have the forms listed next to each other when we add more?