Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-91: Added Jupyter file, input and output images and readme for hole detection #187

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

srimontidutta
Copy link

Issue-91: Added Jupyter, image, and readme files for hole detection.
Hole detection is done through OpenCV, grayscaling, Gaussian blur, blob detection.
#91

Copy link
Owner

@geekquad geekquad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @srimontidutta,
please add sample input and output images in the notebook also.
Thankyou.

@srimontidutta
Copy link
Author

@geekquad I'll have to modify the code then. The code I have written shows the output image in a pop-up to avoid clutter in the notebook.
Is it really necessary to modify the code?

@geekquad
Copy link
Owner

geekquad commented Apr 25, 2021

@geekquad I'll have to modify the code then. The code I have written shows the output image in a pop-up to avoid clutter in the notebook.
Is it really necessary to modify the code?

Hey @srimontidutta,
Yes, that is the amendment I need. It will help people to get a grasp of what you are actually doing by seeing a sample of input and output images.

@srimontidutta
Copy link
Author

@geekquad Then, can I add a folder consisting of the sample input and output images?

@geekquad
Copy link
Owner

@geekquad Then, can I add a folder consisting of the sample input and output images?

You can add the folder but I need them in the notebook as well.
Thankyou.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants