Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Filter by date and region on index, events and partner pages #457

Merged
merged 7 commits into from
Nov 24, 2024

Conversation

katjam
Copy link
Member

@katjam katjam commented Nov 8, 2024

Fixes #408

Description

  • Adds regional selector to index page
  • Moves event lists out of model & instead calculate from filters
  • Correct featured events on index to show draw from all future, not just today

TODO: Would like to add tests for event listings

Huly®: TD-453

@katjam katjam marked this pull request as draft November 8, 2024 18:35
Copy link

cloudflare-workers-and-pages bot commented Nov 8, 2024

Deploying the-trans-dimension with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9f218f2
Status: ✅  Deploy successful!
Preview URL: https://11980f70.the-trans-dimension.pages.dev
Branch Preview URL: https://feat-408-add-regional-select.the-trans-dimension.pages.dev

View logs

@katjam katjam changed the title feat: Add filter upcoming events by region to index feat: Filter by date and region on index, events and partner pages Nov 20, 2024
@katjam katjam marked this pull request as ready for review November 20, 2024 19:33
@kimadactyl
Copy link
Member

Not sure if you want me to review yet but just had a look and looking nice but:

  • Events for manchester not showing up at all - is this just becuase it's not merged into main?
  • Something odd's happened to the news!

@katjam
Copy link
Member Author

katjam commented Nov 24, 2024

The news is missing images because for some reason they don't exit on staging. We did at some point have placeholder images but I'm not sure if I ported that across. I'll check.

There were events in Manchester for some dates. This may be because is using staging data. I'll check that too. Maybe we should temporarily point preview branches at production PlaceCal to verify before merging? I'll make a staging branch again now so we can preview all of these small changes together before going live.

@kimadactyl
Copy link
Member

There were events in Manchester for some dates. This may be because is using staging data. I'll check that too. Maybe we should temporarily point preview branches at production PlaceCal to verify before merging?

Ah right that makes sense! Yes let's build vs prod, right now there's zero events on staging coming through :)

The news is missing images because for some reason they don't exit on staging.

Ah - we only have db sync from prod->staging not storage sync. Prob why!

@katjam katjam changed the base branch from main to staging November 24, 2024 13:28
@katjam
Copy link
Member Author

katjam commented Nov 24, 2024

Merging to staging for preview before we send live this week.

@katjam katjam merged commit 7d8dc61 into staging Nov 24, 2024
1 check passed
@katjam katjam deleted the feat/408-add-regional-selector branch November 24, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add in regional selector
2 participants