Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be less strict with negative moments of inertia #690

Merged
merged 7 commits into from
Oct 23, 2024
Merged

Be less strict with negative moments of inertia #690

merged 7 commits into from
Oct 23, 2024

Conversation

schneiderfelipe
Copy link
Member

@schneiderfelipe schneiderfelipe commented Oct 23, 2024 •
edited
Loading

It turns out zeroing moments of inertia whose absolute value were less than $10^{-63}$ let some real world cases slip, which led to negative rotational temperatures and some NaN sadness.

This PR

  • tests this particular case (as a doctest)
  • fixes this particular case
  • allows selecting a different threshold for the internal function _rotational_temperature
  • EDIT: also fixes CI

@schneiderfelipe schneiderfelipe merged commit 750cdac into main Oct 23, 2024
3 checks passed
@schneiderfelipe schneiderfelipe deleted the fix-rot-temp branch October 23, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@schneiderfelipe