Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better registry handling ✨ #712

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

liquidiert
Copy link
Collaborator

@liquidiert liquidiert commented Oct 14, 2024

  • add registry url cli option for easy registry change
  • fix service annotations
  • fix replacement of kwargs with empty dict by filtering only the empty values

closes #703
closes #670

  - add registry url cli option for easy registry change
  - fix service annotations
  - fix replacement of kwargs with empty dict by filtering only the empty values
@liquidiert liquidiert requested a review from Schille October 18, 2024 10:41
@liquidiert liquidiert requested a review from Schille October 21, 2024 11:43
@Schille
Copy link
Collaborator

Schille commented Oct 29, 2024

With a custom registry link, you must also pass this as env for Stowaway. Otherwise, you'll end up with this component pulled from the default registry:

self.STOWAWAY_IMAGE = config(
"GEFYRA_STOWAWAY_IMAGE", default="quay.io/gefyra/stowaway"
)
self.STOWAWAY_IMAGE_PULLPOLICY = config(

Look for the workload definition of Stowaway in the Operator code to set this env (it's currently not specified and hence uses the default).

  - rename registry param
  - add env vars to operator
  - add stowaway pvc size handling
@crkurz
Copy link

crkurz commented Nov 5, 2024

@Schille ,
it appears this will also solve packet drops due to MTU size when used with CISCO VPN, which is terrific! Thank you!

Nit: for tracking do we need a ticket for MTU size problem and should that ticket be linked to this PR?

@crkurz
Copy link

crkurz commented Nov 5, 2024

@Schille ,
fyi, I have filed GEFYRA-738 for MTU issue. This might need to be linked to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom registry better Gyfera Operator, minimal PVC size
3 participants