Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hook tests for windows #1496

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable hook tests for windows #1496

wants to merge 1 commit into from

Conversation

aljazerzen
Copy link
Contributor

@aljazerzen aljazerzen commented Feb 24, 2025

Ok, as I manually verified, hooks and watch mostly work on windows via WSL.

The problem we still face is that when we invoke a command in WSL, it will run within WLS and think it is on Linux. This means it will look at /root/.config/edgedb for config instead of /mnt/c/Users/username/AppData/Roaming/edgedb.

Which means that gel instance list it will return different list of instances within WSL and outside. That breaks the tests we have for hooks (well, a similar thing with project stash).


We now need to decide between two options:

  • don't run hooks in WSL, but within windows instead. We should think how to execute scripts in this case.
  • patch the CLI (and bindings) to understand that they are running on a linux within WSL and use the config from Windows FS instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant