Rename two API endpoints and add field descriptions to the exported json files #10433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t with human-readable field descriptions
micheles
reviewed
Mar 11, 2025
micheles
reviewed
Mar 11, 2025
micheles
reviewed
Mar 11, 2025
micheles
reviewed
Mar 11, 2025
…_dict() instead of json.loads(df.to_json())
…xpected/aggrisk_tags.csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have also checked that level 1 users can actually use the two API endpoints to retrieve the json data.
In the aggrisk_tags exporter, for each loss type I added a row with total values.
I tried to regenerate expected files for openquake/engine/tests/impact_test.py, but instead of just adding rows with total values, it was doing the aggregation by one field instead of 2 (it's not clear to me why), so I still haven't replaced those files.
I added rows per ID with “injured” and “affectedpop” to the “impact” results in a separate branch (
endpoints_plus2lts).