Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ability to specify "mochaOpts.ui" as function #1039

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: ability to specify "mochaOpts.ui" as function #1039

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/config/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { BrowserConfig } from "./browser-config";
import type { BrowserTestRunEnvOptions } from "../runner/browser-env/vite/types";
import type { Suite, Test } from "../types";
import type { Test } from "../types";
import type { ChildProcessWithoutNullStreams } from "child_process";
import { RequestOptions } from "https";

Expand Down Expand Up @@ -215,7 +215,7 @@ export interface MochaOpts {
isWorker?: boolean;

/** Interface name or path to file with custom interface implementation. */
ui?: string | Suite;
ui?: string | ((suite: unknown) => void);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I made a mistake with the type in the past PR. Suite specified as unknown because I can't use Mocha.Suite and it differ from our testplane suite. Moreover I don't want to describe Mocha.Suite because it has a lot of fields.

}

export interface SystemConfig {
Expand Down
Loading