Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTP 26 to CI #327

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add OTP 26 to CI #327

wants to merge 1 commit into from

Conversation

wingyplus
Copy link
Contributor

No description provided.

@wingyplus wingyplus changed the title Add OTP 26 Add OTP 26 to CI May 17, 2023
@seriyps
Copy link
Collaborator

seriyps commented May 17, 2023

gen_smtp uses erlef/setup-beam action in CI and it was not yet updated to support OTP-26.

So, the options are:

  • Wait for setup-beam to add support for OTP-26
  • Use container-based builds: container: erlang:${{ matrix.otp }} instead of - uses: erlef/setup-beam@v1

@seriyps
Copy link
Collaborator

seriyps commented May 17, 2023

It seems now tests on OTP-26 are failing with

{{case_clause,<<0>>},
 [{gen_smtp_client,read_possible_multiline_reply,1,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,896}]},
  {gen_smtp_client,try_MAIL_FROM,4,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,426}]},
  {gen_smtp_client,try_sending_it,4,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,407}]},
  {gen_smtp_client,send_it,2,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,307}]},
  {gen_smtp_client,'-send/3-fun-0-',3,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,172}]}]}

Will you be able to debug it?

@wingyplus
Copy link
Contributor Author

It seems now tests on OTP-26 are failing with

{{case_clause,<<0>>},
 [{gen_smtp_client,read_possible_multiline_reply,1,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,896}]},
  {gen_smtp_client,try_MAIL_FROM,4,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,426}]},
  {gen_smtp_client,try_sending_it,4,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,407}]},
  {gen_smtp_client,send_it,2,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,307}]},
  {gen_smtp_client,'-send/3-fun-0-',3,
                   [{file,"/home/runner/work/gen_smtp/gen_smtp/src/gen_smtp_client.erl"},
                    {line,172}]}]}

Will you be able to debug it?

I found even using OTP 25. :(

@mworrell
Copy link
Collaborator

mworrell commented Nov 7, 2024

I also saw this test locally. Seems to be something with TLS?

It receives <<21,3,3,0,2,2,10>>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants