Allow sender to immediately hangup after QUIT message #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@arjan Could you have a look at this pull request? |
|
Looks good! |
arjan
approved these changes
Dec 16, 2024
|
@arjan Shall we make a new release? There are quite some changes since the 1.2.0. (I don't have access to the Hex package, so can't release...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a problem where the gen_smtp_server crashes if the client sends a QUIT message and immediately hangs up before the "221 Bye" can be send. This is done by ignoring any send errors.
In the client: be a bit more subtle when receiving funky multiline replies. Do not immediately crash but just throw an "unexpected_response" exception.
Use OTP 25 for docs build, as ex_doc requires it.