buildings.js - small adjustments - no functional change

genbtc · Nov 15, 2023 · efc0812 · efc0812
1 parent 727950b
commit efc0812
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/modules/buildings.js b/modules/buildings.js
@@ -222,7 +222,7 @@ function buyBuildings() {
             if (getBuildingItemPrice(game.buildings.Gym, "wood", false, 1) * Math.pow(1 - game.portal.Resourceful.modifier, game.portal.Resourceful.level) > (game.resources.wood.owned / gymwallpct))
                 skipGym = true;
         }
-        //ShieldBlock cost Effectiveness:
+        //ShieldBlock Cost Effectiveness Factor vs Gym: (DONE: now cost correctly factored in, decided by skipLowBlockHighCost in equipment.js)
         if (game.equipment['Shield'].blockNow) {
             var gymEff = evaluateEquipmentEfficiency('Gym');
             var shieldEff = evaluateEquipmentEfficiency('Shield');
@@ -238,14 +238,14 @@ function buyBuildings() {
     if (!game.buildings.Tribute.locked && (getPageSetting('MaxTribute') > game.buildings.Tribute.owned || getPageSetting('MaxTribute') == -1))
         safeBuyBuilding('Tribute');
 
-    var targetBreed = parseInt(getPageSetting('GeneticistTimer'));
+    var targetBreed = parseInt(getPageSetting('GeneticistTimer') ?? 0);
 //NURSERIES:
     //NoNurseriesUntil', 'No Nurseries Until z', 'For Magma z230+ purposes. Nurseries get shut down, and wasting nurseries early on is probably a bad idea. Might want to set this to    230+ as well.'
     var nursminlvl = getPageSetting('NoNurseriesUntil');
     //Activate dynamic Nurseries to buy nurseries from NoNurseriesUntilZone up to portal before zone.
     function dynamicNurseries() {
         var maxNursery = getPageSetting('MaxNursery');
-        var finalZone = getPageSetting('HeHrDontPortalBefore')
+        var finalZone = getPageSetting('HeHrDontPortalBefore');
         var numZ = finalZone - nursminlvl;
         var perZ = maxNursery / ((numZ / 10 + 1));
         return perZ;
@@ -303,13 +303,14 @@ function buyStorage() {
             jest = simpleSeconds(Bs[B], 45);
             jest = scaleToCurrentMap(jest);
         }
+        //LOWLEVEL CODE
         if ((game.global.world == 1 && owned > max * customVars.storageLowlvlCutoff1) ||
             (game.global.world >= 2 && game.global.world < 10 && owned > max * customVars.storageLowlvlCutoff2) ||
             (owned + jest > max * customVars.storageMainCutoff)) {
             // debug('Buying ' + B + '(' + Bs[B] + ') at ' + Math.floor(game.resources[Bs[B]].owned / (game.resources[Bs[B]].max * packMod * 0.99) * 100) + '%');
-            if (canAffordBuilding(B) && game.triggers[B].done) {
+            if (canAffordBuilding(B) && game.triggers[B].done)
                 safeBuyBuilding(B);
-            }
         }
+		//TODO: Very Like Autostorage, detect that.
     }
 }