Bulk create annotation values #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorjerse
force-pushed
the
feature/annotation_bulk_create
branch
7 times, most recently
from
826e143 to
aa93e69
Compare
dblenkus
reviewed
Nov 17, 2023
dblenkus
reviewed
Nov 17, 2023
gregorjerse
force-pushed
the
feature/annotation_bulk_create
branch
2 times, most recently
from
a8c1575 to
01689e5
Compare
gregorjerse
changed the title
gregorjerse
force-pushed
the
feature/annotation_bulk_create
branch
2 times, most recently
from
209673f to
a378aea
Compare
dblenkus
reviewed
Nov 21, 2023
| for value in group: | ||
| instance = annotation_map[(value["field"], value["entity"])] | ||
| to_delete = value["_value"]["value"] is None | ||
| if to_delete: |
There was a problem hiding this comment.
You can write the expression inline and avoid using another variable.
gregorjerse
force-pushed
the
feature/annotation_bulk_create
branch
from
a378aea to
99a4f85
Compare
dblenkus
approved these changes
Nov 21, 2023
gregorjerse
force-pushed
the
feature/annotation_bulk_create
branch
2 times, most recently
from
b758c97 to
6bcb50e
Compare
gregorjerse
force-pushed
the
feature/annotation_bulk_create
branch
from
6bcb50e to
bab55be
Compare
gregorjerse
force-pushed
the
feature/annotation_bulk_create
branch
from
bab55be to
0df2322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.