Skip to content

Commit

Permalink
net-dialup/minimodem: change default USE; fix test
Browse files Browse the repository at this point in the history 
sndfile is a sort-of lowest common denominator, which
makes it more appropriate as a default-on USE flag
than more desktop-oriented options such as ALSA.

Additionally, a test USE flag was added.  When disabled,
tests are not run.  Tests depend on sndfile.

Closes: https://bugs.gentoo.org/921846
Signed-off-by: Seth M. Price <[email protected]>
  • Loading branch information
@ssterling
ssterling committed Nov 21, 2024
1 parent 486992e commit 2020b1d
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
7 changes: 5 additions & 2 deletions ...dialup/minimodem/minimodem-0.24-r1.ebuild → ...dialup/minimodem/minimodem-0.24-r2.ebuild
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,11 @@ SRC_URI="http://www.whence.com/minimodem/minimodem-${PV}.tar.gz"
LICENSE="GPL-3+"
SLOT="0"
KEYWORDS="~amd64"
IUSE="+alsa pulseaudio sndfile sndio"
REQUIRED_USE+="|| ( alsa pulseaudio sndfile )"
IUSE="alsa pulseaudio +sndfile sndio test"
REQUIRED_USE+="|| ( alsa pulseaudio sndfile )
test? ( sndfile )"

RESTRICT="!test? ( test )"

DEPEND="sndfile? ( media-libs/libsndfile )
sci-libs/fftw:3.0
Expand Down
7 changes: 5 additions & 2 deletions net-dialup/minimodem/minimodem-9999.ebuild → ...dialup/minimodem/minimodem-9999-r1.ebuild
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,11 @@ EGIT_REPO_URI="https://github.com/kamalmostafa/minimodem"

LICENSE="GPL-3+"
SLOT="0"
IUSE="alsa +pulseaudio sndfile sndio"
REQUIRED_USE+="|| ( alsa pulseaudio sndfile sndio )"
IUSE="alsa pulseaudio +sndfile sndio test"
REQUIRED_USE+="|| ( alsa pulseaudio sndfile sndio )
test ( sndfile )"

RESTRICT="!test? ( test )"

DEPEND="sndfile? ( media-libs/libsndfile )
sci-libs/fftw:3.0
Expand Down

3 comments on commit 2020b1d

@antecrescent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, changes to the IUSE defaults don't warrant a revision bump. Also, I've never seen a 9999-r1 live ebuild before which kind of makes sense, since these are inherently unstable and you cannot guarantee that upstream hasn't broken the package yet again since you last propagated the new version.

@ssterling
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Not sure I can really undo what I did here, but I’ll remember it for future changes.

@antecrescent
Copy link
Contributor

@antecrescent antecrescent commented on 2020b1d Nov 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, I wanted to share that for future changes. There's no need to revert this commit.

Please sign in to comment.