Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-p2p/ipfs-desktop-bin: new package, add 0.39.0 #251

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions net-p2p/ipfs-desktop-bin/Manifest
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
DIST ipfs-desktop-0.39.0-linux-amd64.deb 126937128 BLAKE2B 53ab176bb87a81cef9e9e5b968ff8ed2207be691aa19ce95cd45664590cea3a6ce071b67b67883bf3de1cb7e2b4a1fad4df8c64e5590dc8f06f46dd2fc66d543 SHA512 200bbf5289a0f1b091afd6ea102303aba9831da2fb926bb7adf5c22099cf5cee68ae1c533de81c1a11ab7af837fc4609d7caf60b97361ceedc7a2220423ac3e5
76 changes: 76 additions & 0 deletions net-p2p/ipfs-desktop-bin/ipfs-desktop-bin-0.39.0.ebuild
Original file line number Diff line number Diff line change
@@ -0,0 +1,76 @@
# Copyright 2024 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

EAPI=8
inherit desktop xdg unpacker optfeature
DESCRIPTION="A desktop client for IPFS. The IPFS's Native Application"
HOMEPAGE="https://github.com/ipfs/ipfs-desktop"
SRC_URI="https://github.com/ipfs/ipfs-desktop/releases/download/v${PV}/ipfs-desktop-${PV}-linux-amd64.deb"

This comment was marked as resolved.

S="${WORKDIR}"
LICENSE="MIT"
SLOT="0"
KEYWORDS="~amd64"

DEPEND="
"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just remove DEPEND here.

RDEPEND="x11-libs/gtk+:3
x11-libs/libnotify
dev-libs/nss
x11-libs/libXScrnSaver
x11-libs/libXtst
x11-misc/xdg-utils
app-accessibility/at-spi2-core
sys-apps/util-linux
app-crypt/libsecret
dev-libs/expat
dev-libs/glib:2
dev-libs/nspr
media-libs/alsa-lib
media-libs/mesa
net-print/cups
sys-apps/dbus
x11-libs/cairo
x11-libs/gdk-pixbuf:2
x11-libs/libX11
x11-libs/libXcomposite
x11-libs/libXdamage
x11-libs/libXext
x11-libs/libXfixes
x11-libs/libXrandr
x11-libs/libdrm
x11-libs/libxcb
x11-libs/libxkbcommon
x11-libs/pango
"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
QA_PREBUILT="*"

I forgot to mention, but please add QA_PREBUILT since this is a binary ebuild. Otherwise, QA will notify you that it doesn't respect {C,LD}FLAGS.
https://devmanual.gentoo.org/eclass-reference/ebuild/index.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to mention, but please add QA_PREBUILT since this is a binary ebuild. Otherwise, QA will notify you that it doesn't respect {C,LD}FLAGS. https://devmanual.gentoo.org/eclass-reference/ebuild/index.html

Hello... I fix it on WebIDE... sorry


src_prepare(){
default
unpacker "${S}/usr/share/doc/ipfs-desktop/changelog.gz"
}
src_install(){
# clean up build-in kubo
insinto "/opt"
doins -r "${S}/opt/IPFS Desktop"
dosym -r "/opt/IPFS Desktop/ipfs-desktop" "/usr/bin/ipfs-desktop"
domenu "${S}/usr/share/applications/ipfs-desktop.desktop"
dodoc "${S}/changelog"
insinto "/usr/share"
# doins -r "${S}/usr/share/icons"
local size
for size in 16 32 48 64 128 256 512; do
doicon -s ${size} "${S}/usr/share/icons/hicolor/${size}x${size}/apps/ipfs-desktop.png"
done
fperms +x "/opt/IPFS Desktop/ipfs-desktop"
fperms +x "/opt/IPFS Desktop/chrome-sandbox"
fperms +x "/opt/IPFS Desktop/chrome_crashpad_handler"
fperms +x "/opt/IPFS Desktop/resources/app.asar.unpacked/node_modules/kubo/kubo/ipfs"
}

pkg_postinst(){
xdg_pkg_postinst
optfeature "cli interface" net-p2p/kubo
}
pkg_postrm(){
xdg_pkg_postrm
}
15 changes: 15 additions & 0 deletions net-p2p/ipfs-desktop-bin/metadata.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE pkgmetadata SYSTEM "https://www.gentoo.org/dtd/metadata.dtd">
<pkgmetadata>
<maintainer type="person">
<email>[email protected]</email>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the email address you registered with bugs.gentoo.org.

https://wiki.gentoo.org/wiki/Project:GURU#The_regulations

  1. Users that list themselves as maintainers must use an e-mail address known to bugs.gentoo.org in metadata.xml and keep it up to date in case it changes.

Copy link
Contributor Author

@Dawn-Xu-helloworld Dawn-Xu-helloworld Oct 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a alias name for my email registered in bugs.gentoo.org. But I won't leave my phone numbers on GitHub, I wold change my gentoo bugzilla's email.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, Bugzilla wouldn't know whether it's an alias or not.

$ curl 'https://bugs.gentoo.org/rest/[email protected]'
{"code":51,"error":true,"message":"There is no user named '[email protected]'. Either you mis-typed the name or that user has not yet registered for a Gentoo's Bugzilla account.","documentation":"https://bugzilla.readthedocs.org/en/5.0/api/"}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your new email is still not registered. Can you login to Bugzilla with your new email address?

$ curl 'https://bugs.gentoo.org/rest/[email protected]'
{"code":51,"message":"There is no user named '[email protected]'. Either you mis-typed the name or that user has not yet registered for a Gentoo's Bugzilla account.","error":true,"documentation":"https://bugzilla.readthedocs.org/en/5.0/api/"}

<name>Dawn Xu</name>
</maintainer>
<upstream>
<remote-id type = "github">ipfs/ipfs-desktop</remote-id>
<maintainer>
<name>ipfs</name>
<email>[email protected]</email>
</maintainer>
</upstream>
</pkgmetadata>