-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gs7 updateUpdate Here Geocode and Reverse Geocode Provider to GS7 (v7) #1231
base: master
Are you sure you want to change the base?
Conversation
Synced with master @jbelien , thanks again for reviewing |
Hello @patrickghidossi , Thanks for your contribution. I had a first (quick) look to the changes made. Looking at some documentation, I've found this:
I see that you changed some tests, the goal of those tests is to make sure we don't introduce breaking changes ; please keep the tests as they are, only adapt what needs to be adapted. If there are new features in v7, feel free to add extra tests. Before I'll review the code, could you already do the following:
Thanks! |
Updates Here provider to support GS7 under the 0.8.0 version tag. Details in linked issue
Closes #1230