feat: allow "willdurand/geocoder" v5 #1240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jbelien Sorry to nag you. But working in dev with PHP 8.4 is annoying. I need to reload the pages a lot. Because of the deprecation-info page. Is there anything i can do, to push things forward? |
|
@jbelien ping |
|
Thanks @Nyholm for taking care |
|
thanks. are there plans for a new release? |
|
Did you test it? Does it work for you? If it does, it would bring me more confidence to do a release |
|
That is understandable. I have created a PR but i did not figure out yet how to get |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #1209
While i try to use it in symfony with https://github.com/geocoder-php/BazingaGeocoderBundle/blob/master/composer.json
i noticed that the provider need to be updated to.
Or do i miss something?