Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add vi-mode as built-in plugin #184

Closed
wants to merge 2 commits into from
Closed

WIP: Add vi-mode as built-in plugin #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00c00a7
Add vi-mode plugin to built-in plugins
desyncr Nov 18, 2017
6b65cac
Add comments
desyncr Nov 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions plugins/vi-mode/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Vi-mode

Vi-mode plugin.
18 changes: 18 additions & 0 deletions plugins/vi-mode/plugin.zsh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra newline

# For some reason this line doesn't work inside a function, otherwise
# it should be located in the _setup function.
zle -N zle-keymap-select geometry_prompt_vi-mode_render
geometry_prompt_vi-mode_setup() {}

geometry_prompt_vi-mode_check() {}

geometry_prompt_vi-mode_render() {
# Removes previously state
RPROMPT=${${RPROMPT/\[INSERT\] /}/\[NORMAL\] /}
# swaps main/INSERT, vicmd/NORMAL
local KEY=${${KEYMAP/main/INSERT}/vicmd/NORMAL}
# Formats RPROMPT with mode + rest of prompt
RPROMPT="[$KEY] $RPROMPT"
# Resets prompt
zle && zle reset-prompt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this do an extra redraw per prompt line?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I think it can be avoided though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can it be avoided? can we just set a dirty bit somewhere?

}