Added rust translation of nm2rgb.py #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgalis
reviewed
Jul 25, 2022
There was a problem hiding this comment.
Hey @afunsten I'd like to merge this but need a couple changes... please
- purge the binaries and/or tmp files,
tint/Cargo.lock tint/target/release/tint tint/target/.rustc_info.json - don't squash the former python, extend to run each lang for comparison, eg demo python, rust, swift for users to choose
tint/fn.bash tint/README.md tint/fn.bash - change ./src/ to ./src/rust/
- provide a build command and command to install the binary to eg
./bin/rust/tint(assume RUSTUP_HOME and CARGO_HOME are in env)
I'll follow these conventions for nm2rgb.py after the pr. Would be great to demo, compare/contrast the python/rust/swift versions without collisions!!
I reopened the PR and addressed some of the issues. Please have another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample target tested on macOS