Move to cloud composer 2; better handle long-running tasks #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensors for long-running tasks
jmelot
force-pushed
the
35-cloud-composer-2-and-sensors
branch
from
66d1e5c
to
eee4ab6
Compare
|
No need for rebasing 👍 |
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
jmelot
force-pushed
the
35-cloud-composer-2-and-sensors
branch
from
7d39f07
to
b3d2590
Compare
linkage_dag.py
Outdated
|
|
||
| push_to_gcs = BashOperator( | ||
| task_id="push_to_gcs", | ||
| bash_command=f'gcloud compute ssh jm3312@{gce_resource_id} --zone {gce_zone} --command "run_ids_script.sh &"', |
There was a problem hiding this comment.
Where is the run_ids_script.sh file? I couldn't find this one.
There was a problem hiding this comment.
Oh wait, I think you're right and this was a leftover task that wasn't doing anything. Fixed, thanks!!
Add ability to exclude pairs of ids for matching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now splits the long-running simhash and merged id generation task into multiple tasks, using sensors to reduce issues with lost connections.
Also adds linting and moves bucket to cloud composer 2
Closes #35