Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove supplementary materials type #44

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Remove supplementary materials type #44

merged 3 commits into from
Jun 26, 2024

Conversation

rggelles
Copy link
Member

@rggelles rggelles commented Jun 20, 2024

Per #174.

Copy link

github-actions bot commented Jun 20, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 3

Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
300 260 87% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 9810fb5 by action🐍

It looks like these were here even though they're not new? They're removed in our other comparable datasets, and they're not handled in the article schema, so removing them here.
Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jmelot jmelot merged commit c046654 into master Jun 26, 2024
3 of 4 checks passed
@jmelot jmelot deleted the openalex-types branch June 26, 2024 20:18
@jamesdunham jamesdunham removed their request for review July 1, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants