Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error flagged by Jacob #551

Merged
merged 3 commits into from
Sep 30, 2024
Merged

fix error flagged by Jacob #551

merged 3 commits into from
Sep 30, 2024

Conversation

za158
Copy link
Member

@za158 za158 commented Sep 26, 2024

No description provided.

@za158 za158 requested a review from jmelot September 26, 2024 14:39
Copy link

github-actions bot commented Sep 26, 2024

No need for rebasing 👍
behind_count is 0
ahead_count is 3

Copy link

github-actions bot commented Sep 26, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
394 349 89% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
scripts/preprocess.py 85% 🟢
TOTAL 85% 🟢

updated for commit: ff8ca02 by action🐍

Copy link

github-actions bot commented Sep 26, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 83%
83.17% (514/618) 70.77% (339/479) 82.56% (90/109)
Modified Files • (83%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files83.1770.7782.5683.58 
report-only-changed-files is enabled. No files were changed in this commit :)

Copy link
Member

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

There are 3 broken links. Check the code for these links:
1 "('file:///home/runner/work/eto-chip-explorer/eto-chip-explorer/supply-chain/linklist.txt', 'https://tiles.stadiamaps.com/tiles/stamen_terrain/')"
1 "('file:///home/runner/work/eto-chip-explorer/eto-chip-explorer/supply-chain/linklist.txt', 'https://tiles.stadiamaps.com/tiles/stamen_toner/')"
1 "('file:///home/runner/work/eto-chip-explorer/eto-chip-explorer/supply-chain/linklist.txt', 'https://tiles.stadiamaps.com/tiles/stamen_watercolor/')"

@jmelot jmelot merged commit 0ddd701 into main Sep 30, 2024
5 checks passed
@jmelot jmelot deleted the za-updates-9-26 branch September 30, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants