-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add social cards and update dependencies #302
Conversation
Closes #265
Relocate the data fetch code to the page level instead of dashboard component (originally to pass `repoName`, which didn't work, but this location seems like a cleaner location for it). Update the page title to reflect the project/package name, not just ORCA. Integrate `lang` attribute into `<html>` tag.
Decouple the dependency link between `@eto/social-cards` and `@eto/eto-ui-components` so that we can add the social cards without upgrading the UI Components library (which currently fails the tests on later versions).
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
JavaScript CoverageSummary
Modified Files • (83%)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice, thanks for the cleanup as well!
No need for rebasing 👍 |
One other note... the pypi downloads seem to have disappeared. I don't think that's related to this PR though, I see it in production as well, I'll look into that separately. |
repoName
to the meta tag wrapper, which didn't work out, but this location seems like a cleaner location for the fetch logic than the component.Closes #265