Add social cards and update dependencies #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #265
Relocate the data fetch code to the page level instead of dashboard component (originally to pass `repoName`, which didn't work, but this location seems like a cleaner location for it). Update the page title to reflect the project/package name, not just ORCA. Integrate `lang` attribute into `<html>` tag.
Decouple the dependency link between `@eto/social-cards` and `@eto/eto-ui-components` so that we can add the social cards without upgrading the UI Components library (which currently fails the tests on later versions).
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
JavaScript CoverageSummary
Modified Files • (83%)
|
jmelot
approved these changes
Mar 12, 2024
|
No need for rebasing 👍 |
|
One other note... the pypi downloads seem to have disappeared. I don't think that's related to this PR though, I see it in production as well, I'll look into that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repoNameto the meta tag wrapper, which didn't work out, but this location seems like a cleaner location for the fetch logic than the component.Closes #265