Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social cards and update dependencies #302

Merged
merged 5 commits into from
Mar 12, 2024
Merged

Add social cards and update dependencies #302

merged 5 commits into from
Mar 12, 2024

Conversation

brianlove
Copy link
Contributor

  • Add social cards to pages
  • Update dependencies
  • Relocate the data fetch code to the page level instead of the dashboard component. This was originally done to be able to pass repoName to the meta tag wrapper, which didn't work out, but this location seems like a cleaner location for the fetch logic than the component.
  • Update the page title to reflect the project/package name, not just ORCA

Closes #265

Relocate the data fetch code to the page level instead of dashboard
component (originally to pass `repoName`, which didn't work, but this
location seems like a cleaner location for it).

Update the page title to reflect the project/package name, not just
ORCA.

Integrate `lang` attribute into `<html>` tag.
Decouple the dependency link between `@eto/social-cards` and
`@eto/eto-ui-components` so that we can add the social cards without
upgrading the UI Components library (which currently fails the tests
on later versions).
@brianlove brianlove requested a review from jmelot March 8, 2024 16:28
@brianlove brianlove self-assigned this Mar 8, 2024
Copy link

github-actions bot commented Mar 8, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
549 167 30% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: 41f7de8 by action🐍

Copy link

github-actions bot commented Mar 8, 2024

JavaScript Coverage

Summary

Lines Statements Branches Functions
Coverage: 83%
83.66% (384/459) 69.47% (198/285) 81.37% (83/102)
Modified Files • (83%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files83.6669.4781.3783.17 
components80.9268.9978.0480.34 
   MetaTagsWrapper.jsx00006–13
   project_details.js000026–243

Copy link
Contributor

@jmelot jmelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice, thanks for the cleanup as well!

Copy link

No need for rebasing 👍
behind_count is 0
ahead_count is 5

@jmelot
Copy link
Contributor

jmelot commented Mar 12, 2024

One other note... the pypi downloads seem to have disappeared. I don't think that's related to this PR though, I see it in production as well, I'll look into that separately.

@jmelot jmelot merged commit e58b765 into main Mar 12, 2024
4 checks passed
@jmelot jmelot deleted the 265-add-social-card branch March 12, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No preview image on social platforms
2 participants