Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for static pkg-config Windows build #492

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

PaulWagener
Copy link
Contributor

@PaulWagener PaulWagener commented Dec 15, 2023

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Defers the gdal_i.lib missing message until after the pkg-config check and outputs pkg-config metadata in case of a static build.

@lnicola
Copy link
Member

lnicola commented Dec 15, 2023

Bah, this script is so hard to follow.

Can you please add a changelog entry?

@PaulWagener
Copy link
Contributor Author

Done

@lnicola
Copy link
Member

lnicola commented Dec 16, 2023

I can't really verify this, but it seems reasonable.

@lnicola lnicola merged commit 4d035df into georust:master Dec 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants