Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new geo-traits crate #1019

Closed
wants to merge 17 commits into from
Closed

Add new geo-traits crate #1019

wants to merge 17 commits into from

Commits on Feb 9, 2023

  1. Base traits implementation

    @kylebarron
    kylebarron committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    91e159b View commit details
    Browse the repository at this point in the history

  2. Implement geometry collection trait

    @kylebarron
    kylebarron committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    edb6c6c View commit details
    Browse the repository at this point in the history

  3. remove comments

    @kylebarron
    kylebarron committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    9cdca40 View commit details
    Browse the repository at this point in the history

  4. simpler type

    @kylebarron
    kylebarron committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    bec4fdc View commit details
    Browse the repository at this point in the history

  5. small fixes

    @kylebarron
    kylebarron committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    f63803e View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Merge branch 'main' into kyle/traits-v2

    @kylebarron
    kylebarron committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    f87562a View commit details
    Browse the repository at this point in the history

  2. Initial geo-traits implementation

    @kylebarron
    kylebarron committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    2b04f25 View commit details
    Browse the repository at this point in the history

  3. remove traits import from geo

    @kylebarron
    kylebarron committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    6dcba58 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Address comments

    @kylebarron
    kylebarron committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    046704b View commit details
    Browse the repository at this point in the history

  2. make linestring item a coord trait

    @kylebarron
    kylebarron committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    cf3a51d View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2023

  1. Bump geo-traits msrv

    @kylebarron
    kylebarron committed Apr 22, 2023
    Configuration menu
    Copy the full SHA
    6413405 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2023

  1. Merge branch 'main' into kyle/traits-v3

    @kylebarron
    kylebarron committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    7d639fe View commit details
    Browse the repository at this point in the history

  2. Use ExactSizeIterator

    @kylebarron
    kylebarron committed Jun 16, 2023
    Configuration menu
    Copy the full SHA
    10cdce0 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Merge #1011 

    1011: Initial geo-traits implementation r=frewsxcv a=kylebarron

- [x] I agree to follow the project's [code of conduct](https://github.com/georust/geo/blob/main/CODE_OF_CONDUCT.md).
- [ ] I added an entry to `CHANGES.md` if knowledge of this change could be valuable to users.
---

As discussed on the discord, in #838, and originally in #67, this is an initial bare-bones implementation of geometry access traits for discussion. As `@frewsxcv` suggested, for now this is a separate crate in the workspace to let us iterate on some ideas.

### Future work

#### Minimize cloning in the geo-types implementation

I got lost in lifetime errors so to get things to compile I added cloning to the geo-types implementations. I.e. for `MultiPoint` each point is cloned when accessed.

Co-authored-by: Kyle Barron <[email protected]>
    @bors @kylebarron
    bors[bot] and kylebarron authored Jun 21, 2023
    Configuration menu
    Copy the full SHA
    1b9557f View commit details
    Browse the repository at this point in the history

  2. Add geo-traits to CI

    @frewsxcv
    frewsxcv authored Jun 21, 2023
    1 Configuration menu
    Copy the full SHA
    e952ed1 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2023

  1. Remove unneeded trait lifetime in geo-traits (#1114) 

    * Merge branch 'main'

* Remove unneeded trait lifetime in geo-traits

* bump MSRV for geo-traits CI

---------

Co-authored-by: Michael Kirk <[email protected]>
    @kylebarron @michaelkirk
    kylebarron and michaelkirk authored Nov 27, 2023
    Configuration menu
    Copy the full SHA
    f116527 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2023

  1. remove clone in geo trait (#1121)

    @kylebarron
    kylebarron authored Nov 28, 2023
    Configuration menu
    Copy the full SHA
    6b44e27 View commit details
    Browse the repository at this point in the history