Fix point-linestring intersection #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By re-using the point-line-containment algorithm on each segment
michaelkirk
reviewed
Aug 21, 2020
| && (point.y() > line.start.y.min(line.end.y)) | ||
| && (point.y() < line.start.y.max(line.end.y))) | ||
| { | ||
| // This is a duplicate of the line-contains-point logic in the "intersects" module |
There was a problem hiding this comment.
ah yes, great shame be on us all.
These algorithms exist in geo-types so we can have a nice rstar integration, right?
There was a problem hiding this comment.
Yep, although as we have now discovered they can easily get out of whack and cause problems, so I'd love to find some better way of providing the functionality, although the reason it's done like this is to avoid circular dependencies 😩
michaelkirk
approved these changes
Aug 21, 2020
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #452, and harmonizes the algorithm in our hidden and shameful
private_utilsmodule with the logic we use elsewhere.